Use trybuild for testing expected proc macro errors #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TeXitoi
approved these changes
Jun 19, 2019
|
Thanks again! |
sphynx
added a commit
to sphynx/structopt
that referenced
this pull request
Jun 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #199
I tried to cover most of the "panics" from procedural macros in
attrs.rsand to create at least one test for every panic.By the way, those tests will be quite helpful to check whether the introduction of custom attributes parser (PR #198) preserves error messages well. Therefore, I propose to merge this PR first, then I'll rebase my parser changes from #198 on that and will update the tests or fix the error messages accordingly.